Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bracketed paste doesn't ignore \cc/SIGINT #5888

Open
faho opened this issue May 22, 2019 · 5 comments
Open

Bracketed paste doesn't ignore \cc/SIGINT #5888

faho opened this issue May 22, 2019 · 5 comments
Labels
bug Something that's not working as intended
Milestone

Comments

@faho
Copy link
Member

faho commented May 22, 2019

You know how bracketed paste is supposed to prevent you from executing commands?

$ echo \cc echo hahaha\n | xsel --clipboard # or pbcopy or whatever
# Now paste
$  echo hahaha
hahaha # executed automatically
$ [201~

I'm not quite sure what happens here? Do we get a SIGINT and react to that by exiting paste mode? Is it because we're in a function and then happen to exit?

(Note that some terminals protect against this by asking if they should paste an unprintable character, fish_clipboard_paste is unaffected)

@faho faho added the bug Something that's not working as intended label May 22, 2019
@faho faho added this to the fish 3.1.0 milestone May 22, 2019
@floam
Copy link
Member

floam commented May 22, 2019

Terminal.app for me offers the dialog asking if I really want to paste a control character only if bracketed paste mode is not enabled. I get no dialog in fish but I do in bash or fish_key_reader. It seems like they expect that I should be safe when in bracketed paste mode.

@floam
Copy link
Member

floam commented May 22, 2019

The zsh 5.3 macOS ships with also leaves bracketed paste mode if I paste \cc.

@floam
Copy link
Member

floam commented May 22, 2019

@zanchey zanchey modified the milestones: fish 3.1.0, fish-future Sep 25, 2019
@zanchey
Copy link
Member

zanchey commented Sep 25, 2019

Pushing this out to fish-future

@faho
Copy link
Member Author

faho commented Apr 3, 2024

Not fixed by #10359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that's not working as intended
Projects
None yet
Development

No branches or pull requests

3 participants