Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build broken by ncurses/term.h in builtin_set_color on FreeBSD #594

Closed
zanchey opened this issue Feb 23, 2013 · 4 comments
Closed

build broken by ncurses/term.h in builtin_set_color on FreeBSD #594

zanchey opened this issue Feb 23, 2013 · 4 comments
Milestone

Comments

@zanchey
Copy link
Member

zanchey commented Feb 23, 2013

a355cf2 breaks the build on FreeBSD 9.1, presumably due to some interaction between ncurses.h and term.h.

g++ -I/usr/local/include/ -D_LARGEFILE_SOURCE=1 -D_FILE_OFFSET_BITS=64 -Wall -DLOCALEDIR=\"/opt/share/locale\" -DPREFIX=L\"/opt\" -DDATADIR=L\"/opt/share\" -DSYSCONFDIR=L\"/opt/etc\"  -c builtin.cpp
In file included from builtin_set_color.cpp:19,
                 from builtin.cpp:393:
/usr/include/term.h:755: error: expected unqualified-id before numeric constant
/usr/include/term.h:755: error: expected `)' before numeric constant
*** [builtin.o] Error code 1
@KamilaBorowska
Copy link
Contributor

Confirming. I've installed FreeBSD today (but not to test this bug).

@ridiculousfish
Copy link
Member

This code is screwing up term.h:

    /**
   BSD del_curterm seems to do a double-free. We redefine it as a no-op
*/
#define del_curterm(oterm) OK
#endif

@ridiculousfish
Copy link
Member

This ought to fix it
To git@github.com:fish-shell/fish-shell.git
d89fcdc..c55cbd3 master -> master

@ridiculousfish
Copy link
Member

Looks successful. Thanks for reporting this!

@zanchey zanchey added this to the fish 2.0 (first stable release) milestone Dec 7, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants