Escape dollar sign in completions inside double quotes

[krobelus]

Motivating example: Run touch 'foo$' and type ls "foo<TAB>

Current result: ls "foo$"
Result with this change: ls "foo\$"

---

TODOs:

• Changes to fish usage are reflected in user documentation/manpages.
• Tests have been added for regressions fixed
• User-visible changes noted in CHANGELOG.md

[zanchey]

I don't really understand your example - can you clarify? Is the echo supposed to be ls or some other command that accepts filenames?

[krobelus]

Oh right, it doesn't work with echo, I corrected the example now

[mqudsi]

Can you please add it the same way the \ is currently escaped? It's a switch statement, we should strive to use it.

fish-shell/src/parse_util.cpp

Lines 548 to 550 in 5a2d919

	case L'\\':
	result.append({L'\\', L'\\'});
	break;

[mqudsi]

Merged. Thanks.