Replace debug() with flog #6511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace with FLOGF.
This is meant to show messages related to what a terminal supports. In particular which color or emoji it can handle.
This used debug level 5, which means it was basically unusable.
One for usable messages, another for the chatty ones. Use like `--debug=parse-productions'*'`.
These were level 5, so I'd bet nobody ever saw them
Useful to figure out if a flog category is enabled. We only use it in one place, but it seems like the sort of thing that should exist.
For both input and reader, because the "reader" term is more general and we don't have enough messages to justify multiple categories
These are related to *signal handlers* in fish_key_reader, and I don't think this code needed to be touched since it was added.
I'm not *super*-happy with this, because pgroups and terminal ownership and such are quite entertwined. But hey, if all fails just use `proc'*'`
Please wait! |
|
Just checking if you're paying attention 😈 |
|
Okay, let's merge this now (to master, I'm not a monster!) because it's very likely to go stale fast. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This turns all debug() calls into
FLOGorFLOGFas needed.In doing so it increases the number of flog categories from 17 to 29.
It doesn't yet remove the debug code, in particular both
fishandfish_indent(which has one total warning) read numbers for--debug, but then don't print anything, and the debug macro and implementation still exist.Very few debug messages have been removed without replacement, these are ones I judged to be of no use, especially if they were at debug level > 2, because I recall that being super spammy. If we ever need them we can add them back.
I would like input regarding the categories and their naming. This is a user interface, and naming categories in a way that users have an idea which they should enable is good, even if the users end up being just the fish-shell members.
Also: Should we add this for 3.1 still, or wait for 3.2?
TODOs: