Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/iothread.cpp:308:5: error: 'memset' was not declared in this scope on OpenIndiana #6553

Closed
Mno-hime opened this issue Jan 30, 2020 · 1 comment
Assignees
Labels
bug
Milestone

Comments

@Mno-hime
Copy link

@Mno-hime Mno-hime commented Jan 30, 2020

Building fish 3.1 beta1 on OpenIndiana with GCC 6.5 fails with

[ 61%] Building CXX object CMakeFiles/fishlib.dir/src/iothread.cpp.o
In file included from /usr/include/sys/types.h:640:0,
                 from /usr/include/pthread.h:36,
                 from /export/home/newman/ws/oi-userland/components/shell/fish/fish-3.1b1/src/iothread.h:5,
                 from /export/home/newman/ws/oi-userland/components/shell/fish/fish-3.1b1/src/iothread.cpp:3:
/export/home/newman/ws/oi-userland/components/shell/fish/fish-3.1b1/src/iothread.cpp: In function 'bool iothread_wait_for_pending_completions(long int)':
/export/home/newman/ws/oi-userland/components/shell/fish/fish-3.1b1/src/iothread.cpp:308:5: error: 'memset' was not declared in this scope
     FD_ZERO(&fds);
     ^
At global scope:
cc1plus: warning: unrecognized command line option '-Wno-redundant-move'
cc1plus: warning: unrecognized command line option '-Wno-implicit-fallthrough'
make[3]: *** [CMakeFiles/fishlib.dir/build.make:795: CMakeFiles/fishlib.dir/src/iothread.cpp.o] Error 1

Adding #include <string.h> to src/iothread.cpp is all what it takes to build.

@zanchey zanchey added this to the fish 3.1.0 milestone Jan 30, 2020
@zanchey zanchey self-assigned this Jan 30, 2020
@zanchey zanchey added the bug label Jan 30, 2020
@zanchey
Copy link
Member

@zanchey zanchey commented Jan 30, 2020

Fixed on Integration_3.1.0 and merged to master - thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug
Projects
None yet
Development

No branches or pull requests

2 participants