src/iothread.cpp:308:5: error: 'memset' was not declared in this scope on OpenIndiana

[Mno-hime]

Building fish 3.1 beta1 on OpenIndiana with GCC 6.5 fails with

[ 61%] Building CXX object CMakeFiles/fishlib.dir/src/iothread.cpp.o
In file included from /usr/include/sys/types.h:640:0,
                 from /usr/include/pthread.h:36,
                 from /export/home/newman/ws/oi-userland/components/shell/fish/fish-3.1b1/src/iothread.h:5,
                 from /export/home/newman/ws/oi-userland/components/shell/fish/fish-3.1b1/src/iothread.cpp:3:
/export/home/newman/ws/oi-userland/components/shell/fish/fish-3.1b1/src/iothread.cpp: In function 'bool iothread_wait_for_pending_completions(long int)':
/export/home/newman/ws/oi-userland/components/shell/fish/fish-3.1b1/src/iothread.cpp:308:5: error: 'memset' was not declared in this scope
     FD_ZERO(&fds);
     ^
At global scope:
cc1plus: warning: unrecognized command line option '-Wno-redundant-move'
cc1plus: warning: unrecognized command line option '-Wno-implicit-fallthrough'
make[3]: *** [CMakeFiles/fishlib.dir/build.make:795: CMakeFiles/fishlib.dir/src/iothread.cpp.o] Error 1

Adding #include <string.h> to src/iothread.cpp is all what it takes to build.

[zanchey]

Fixed on Integration_3.1.0 and merged to master - thanks!