cmake: adjust logic so variadic tparm is used on NetBSD curses. #6626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coypoop
force-pushed
the
tparm-nbcurses
branch
from
1c548ba
to
8d9fb43
Compare
|
Sorry for the noise, I was testing if some part was actually necessary (it was) and accidentally made a commit like that. |
|
I'm not entirely sure what I'm looking at here. What does this improve or fix? |
|
Ah, okay. So this makes it so we don't use our awful "solaris kludge" on NetBSD, instead relying on the actual working That would be an improvement, yes. |
faho
reviewed
Feb 19, 2020
faho
reviewed
Feb 19, 2020
- Define it before the headers so they can pick the variadic tparm prototype. - We need a TPARM_VARARGS define, add it to config_cmake.h. - Move & adjust comment - put it near the code, and mentiont that NetBSD curses doesn't need the kludge. Now variadic tparm is used on NetBSD instead of the Solaris kludge.
coypoop
force-pushed
the
tparm-nbcurses
branch
from
cc97653
to
9750db5
Compare
|
Merged, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
where tparm would be defined.
TPARM_VARARGS, and simplify logic.