Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing --physical and --logical long options to pwd command? #6787

Closed
Delapouite opened this issue Mar 21, 2020 · 3 comments
Closed

Add missing --physical and --logical long options to pwd command? #6787

Delapouite opened this issue Mar 21, 2020 · 3 comments

Comments

@Delapouite
Copy link
Contributor

Hi

When I let fish autocomplete pwd options, I get the following:

image

But then, since the builtin pwd command has no long option --physical:

image

Should --physical and --logical be added to the fish builtin?

@faho faho added this to the fish 3.2.0 milestone Mar 21, 2020
@faho
Copy link
Member

faho commented Mar 21, 2020

Yeah, the completions are wrong, these options don't exist.

So let's make them right - we don't typically do short-only options.

@ammgws
Copy link
Contributor

ammgws commented Mar 21, 2020

So the conclusion is to add the long options to the pwd builtin?

Would end up matching the system command, for what it matters:
image

@faho faho closed this as completed in 638a66c Mar 21, 2020
@faho
Copy link
Member

faho commented Mar 21, 2020

Yup, and it's done.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants