fix pushd's behavior with invalid arguments #6947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faho
reviewed
Apr 26, 2020
faho
reviewed
Apr 26, 2020
faho
reviewed
Apr 26, 2020
|
Yeah, that'll do. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pushdcurrently adds$PWDto$dirstackwithout checking whether the directory change was successful. For example,pushd ~/.config/fish/config.fishfrom~will add prepend~to$dirstack, even though pushd was given an invalid argument. This also applies to directories the user may not have permission tocdinto. The change in question fixes this.TODOs: