fish_exit doesn't fire when terminal window is closed

[andreiborisov]

Function defined as

function my_function --on-event fish_exit
end

doesn't fire when Terminal.app (or iTerm) window is closed on macOS.

Is this expected behavior? If so, how can I fire my_function when the terminal window is closed?

I've also tried:
--on-process-exit $fish_pid
--on-signal SIGTERM
--on-signal SIGKILL

No success.

P.S. my_function is fired after executing exit command in the terminal window, but I need to be able to run it when the window is closed too.

fish, version 3.1.2
macOS 10.15.4
Terminal.app 2.10

[faho]

What exactly are you doing? What function are you using?

E.g. if I do

function idea --on-event fish_exit
    date >> /tmp/idied
end

that leaves a timestamp in the file /tmp/idied in my tests. This is on linux, so it's possible there's some macOS weirdness.

[zanchey]

The event doesn't work for me on macOS or Linux when fish receives the SIGHUP signal, such as by kill-window in tmux or similar. Running through the debugger shows the event firing, but not the external process starting.

[andreiborisov]

@faho thank you for your answer!☺️

It does not seem to be related to a particular function I'm using because your example doesn't work for me either.

[mqudsi]

When SIGHUP is encountered, a flag is set to end the read loop (s_exit_forced). No new executions are allowed through when this flag is present, and it's set before the fish_exit event is fired. As @zanchey says, the event is fired but nothing is executed.