Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing more prompts in the pager about available action keys #7026

Open
psychoslave opened this issue May 21, 2020 · 4 comments
Open

Providing more prompts in the pager about available action keys #7026

psychoslave opened this issue May 21, 2020 · 4 comments

Comments

@psychoslave
Copy link

psychoslave commented May 21, 2020

The behaviour observed is as of Fish version 3.0.2.

So I just discovered that when the completion menu is triggered, it's possible to to filter interactively the list. That's wonderful. But I had to log the documentation to become aware of that.

When there are many entries, Fish is courteous enough to not throw a full screen of them, but limit that to a 4×3 matrix and a gentle line saying …and 740 more rows are also judged as possible candidates for completion.

Now, that's already a decent behaviour. But I would feel that as an improvement if the gentle line could be turned to something like [744 proposals] ↓ then ← →↑↓ to pick, ⭾ for the full list, <C-s> to sieve, ␛ to discard.

And once <tab> pressed, rather than rows 1 to 49 of 744, something like [744 proposals] ← → ↑↓ ⭻⭽ ⭾ or <S-⭾> to browse, ⏎ to validate, ␛ to discard

By the way, I took the number from a trial on dnf install <tab>, and I find strange that with the 12 initial items plus 740 more, I end up with 744. Ever this is just an inconsistency in paging, or there's an error in the bug, isn't it?

What's your opinion?

@zanchey
Copy link
Member

zanchey commented May 21, 2020

There's definitely some concern about the discoverability of the pager search - many discussions in #2249. One of the problems is that all these keys can be re-bound to something else, so listing the defaults might confuse people. The rebinding might be done by a theme rather than the user directly.

@zanchey zanchey added this to the fish-future milestone May 21, 2020
@zanchey zanchey changed the title RFC on providing more feedback in the completion menu about available action keys Providing more prompts in the pager about available action keys May 21, 2020
@krobelus
Copy link
Member

and I find strange that with the 12 initial items plus 740 more, I end up with 744

It says 740 more rows, not items; the initial 4 rows happen to fit 12 items in your case.

@psychoslave
Copy link
Author

Thanks @krobelus now it makes far more sense. Although I'm guilty of not having thought about it more carefully, I would regard this as an improvement to use a consistent numbering unit. Maybe I should open a new issue on this particular point?

@krobelus
Copy link
Member

krobelus commented Jun 4, 2020

I think it is consistent already; of course suggestions for improvement are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants