Cannot call help using msys2

[malobre]

fish version 3.1.2

Msys2 has the cygpath command but no cygstart.

This result in cygpath not being called:

fish-shell/share/functions/help.fish

Lines 139 to 143 in 27f9920

	# For Windows (Cygwin and WSL), we need to convert the base help dir to a Windows path before converting it to a file URL
	# but only if a Windows browser is being used
	if type -q cygpath
	and string match -qr cygstart $fish_browser[1]
	set page_url file://(cygpath -m $__fish_help_dir)/$fish_help_page

When no browser are set and since it doesn't find cygstart it defaults to cmd.exe however because cygpath is not called the path is wrong which make this : /c/Windows/System32/cmd.exe /c 'start file:///usr/share/doc/fish/index.html' fail.

Instead of exiting with an error it then returns to cmd, typing exit will return to fish:

From my understanding this could be resolved by changing the code quoted above to this:

        if type -q cygpath
            and string match -qr 'cygstart|.*cmd\.exe' $fish_browser[1]
            set page_url file://(cygpath -m $__fish_help_dir)/$fish_help_page

I can submit a push request if needed.

Edit: I updated the regex from cygstart|cmd\.exe to cygstart|.*cmd\.exe

[malobre]

I found why it doesn't return to fish.

Msys2 convert this:
/c/Windows/System32/cmd.exe /c 'start file:///usr/share/doc/fish/index.html'
to this:
C:/Windows/System32/cmd.exe C:/ 'start file:///usr/share/doc/fish/index.html'

This behavior is documented here.

To prevent this from happening, this:

fish-shell/share/functions/help.fish

Line 182 in 27f9920

$fish_browser /c "start $page_url"

could be changed to:

        $fish_browser " /c" "start $page_url"

[zanchey]

That's wild.

Does that change actually help? I don't have MSYS2 installed, just the Git for Windows Bash, but when testing with /c/Windows/system32/cmd.exe " /c" "start notepad.exe" I get an error complaining about the quoting. Dropping the quotes around the second argument helps but I'm not sure how that works on other platforms.

[malobre]

Old post

Yes the quotes makes it work under msys2.

I will look for a solution later today. I think we might be able to check if we're running msys2 with an env variable and then do whatever is necessary.

Edit: I misread your comment, I had also deleted the quotes around the second argument.

[malobre]

Old post

Nevermind !

I had remove the second pair of quotes, could you test this:
/c/Windows/system32/cmd.exe " /c" start notepad.exe

It works with msys2 and with cmd directly, I think it should work with Git for Windows too.

Edit: I misread your comment.

To summarize, this /c/Windows/system32/cmd.exe " /c" start notepad.exe works with:

• cmd
• msys2
• mingw32 / mingw64
• Git for Windows Bash
• PowerShell

[malobre]

I also noticed that dots are not escaped at multiple places (.exe instead of \.exe):

fish-shell/share/functions/help.fish

Line 145 in 27f9920

and string match -qr '.exe' $fish_browser[1]

fish-shell/share/functions/help.fish

Line 174 in 27f9920

and string match -qr '.exe' $fish_browser[1]

fish-shell/share/functions/help.fish

Line 181 in 27f9920

if string match -qr 'cmd.exe$' -- $fish_browser[1]

Is this voluntary? Should I update those when I make a PR for the previously mentioned changes ?

[krobelus]

Should I update those when I make a PR

Sure, that can't hurt.