Selecting previous command forgets trailing escaped space

[Shizcow]

Problem and Reproduction

Take the following command (where there is a space after \, making it escaped)

echo \ 

The command will execute properly. However, when pressing up to re-use the previous command, the trailing space is removed. While removing trailing spaces is usually a good idea, I don't think this should be the case when the last space is escaped.

As this seems like a pretty simple fix, I'd be happy to try my hand at fixing -- assuming this is indeed a bug and someone doesn't beat me to it!

System Info

Fish version: 3.1.2
OS: Arch Linux
Present when customizations are disabled

[krobelus]

Yeah, looks like a bug. The space trimming is historical behavior. I think we could exercise a tokenizer_t here to tell real spaces from escaped ones.

[ridiculousfish]

@Shizcow yeah seems like it should be a straightforward fix, if you know a little C++. krobelus showed the source location, you could enhance that to only trim spaces that have zero preceding \ (or have an even number).

[Shizcow]

Yeah, just had some schoolwork to finish before I could put any time towards anything else. Everything should be in order now.

[ridiculousfish]

Merged the PR as cff5aa9, thank you!