Indent line continuations #7694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! Nice tests! |
Probably not necessary for the next commit, but this way feels more logical
Similar to what fish_indent does. After typing "echo \" and hitting return, the cursor will be indented. A possible annoyance is that when you have multiple indented lines echo 1 \ 2 \ 3 \ 4 \ If you remove lines in the middle with Control-k, the lines below the deleted one will start jumping around, as they are disconnected from and reconnected to "echo".
krobelus
force-pushed
the
indent-line-continuations
branch
from
28127df
to
fb7db1d
Compare
|
Thanks! I took another look, this should be good to go. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to what fish_indent does. After typing "echo " and hitting return,
the cursor will be indented.
A possible annoyance is that when you have multiple indented lines
If you remove lines in the middle with Control-k, the lines below
the deleted one will start jumping around, as they are disconnected
from and reconnected to "echo".
TODOs: