Release 3.2.1

[faho]

As we've expected, there are a few minor-ish issues with 3.2.0, so we should probably make a 3.2.1 bugfix release.

Any discussion of that should go here, otherwise we have the milestone.

Personally I feel all commits currently on master could go in, except for dropping RHEL 6 - that should be kept alive with the 3.2 branch (sorry!)

I've pushed a branch with that to https://github.com/faho/fish-shell/tree/Integration_3.2.1

[ridiculousfish]

Branching off of master seems fine to me, I will hold back on breaking stuff for a bit!

[zanchey]

The RHEL changes can just be reverted, that's fine.

[mqudsi]

@zanchey I think the bit about which tarball to download in the release notes:

The file downloaded from "Source code (tar.gz)" will not build correctly.

is detritus from back-in-the-day when the git repo didn't contain the autoconf-generated ./configure script and is no longer relevant? If so, can we remove that line from the latest release notes and drop it going forward to prevent any confusion?

[faho]

is detritus from back-in-the-day when the git repo didn't contain the autoconf-generated ./configure script and is no longer relevant? If so, can we remove that line from the latest release notes and drop it going forward to prevent any confusion?

Nope, it's still relevant - the autogenerated tarball won't figure out its version, falling back to "unknown" (this is also checked in the tests, which fail as a result).

We might make that work if we just added a file that includes the last tagged version, and if we can't figure out the version via git just use that one, so the autogenerated tarball just uses that?

It would break in case someone were to build something that isn't exactly the tagged version because they'd then get the tag, but I don't believe that's any worse.

[faho]

Alright, as far as I'm concerned 3.2.1 is good to go. #3978 and #7811 are both quite non-critical and there's some nice fixes already in.

[zanchey]

The other problem with the auto-generated tarball is that it doesn't contain generated documentation, which has always been shipped in an attempt to reduce the build dependencies (especially when fish documentation still used Doxygen).

[faho]

Is that still worth it? I would imagine adding sphinx isn't an issue for packagers (it was available everywhere I looked) and even for users building themselves the worst that can happen is they get online documentation.

[zanchey]

Doxygen was fairly heavyweight and also had some excitingly version-dependent behaviour from memory. The only question with Sphinx is whether a new enough version is available in older platforms.