Handle right prompts in webconfig #7930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets fish to print the right prompt of any sample if it has any, and then shows it separately. If there is a right prompt, it will also save it. If not, it will *not* overwrite an existing right prompt.
Some features: - A nice `►` prompt char with a fallback for non-utf8 systems - The $PWD is colored depending on its sha, so different directories are colored differently, but each directory stays the same - User@Host is only shown if not on the local machine (ssh or virtualization) - A right prompt with a nice git display, date, duration of the last command (if it took over 100ms), and virtualenv
|
Changed the layout by removing the spacer div, instead letting the left prompt grow. It now looks like
|
|
This looks great to me! Awesome! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows webconfig to show and save fish_right_prompt if it is defined in a sample (or the current prompt).
It will not remove an existing fish_right_prompt if there is one.
It looks like this:
Fixes issue #736 (at least for fish_right_prompt, I don't think we need more).
In addition (and this is optional, it was just nice to get a better screenshot), this adds a slightly simplified version of my own prompt as the "Disco" sample. Here's a preview:
(the $PWD color depends on the sha of $PWD - this requires sha256sum to be available. if not it'll gracefully fallback to $fish_color_cwd. It will also only show user@host if necessary)
TODOs: