Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completions for nodeenv v1.6.0 #8533

Merged
merged 1 commit into from
Dec 11, 2021
Merged

Add completions for nodeenv v1.6.0 #8533

merged 1 commit into from
Dec 11, 2021

Conversation

andmis
Copy link
Contributor

@andmis andmis commented Dec 7, 2021

Description

This adds completions for nodeenv (see also on PyPI), a popular tool for managing Node.js versions installed in virtual environments.

nodeenv is written in Python, and I made a little script for auto-generating completions for Python commands (using reflection on Python's argparse).

image

@zanchey
Copy link
Member

zanchey commented Dec 8, 2021

These descriptions are all pretty long - is it possible to tidy them up a bit?

@andmis
Copy link
Contributor Author

andmis commented Dec 8, 2021

Yeah, sorry, I should have looked more carefully. Here are the updated strings:

image

@krobelus
Copy link
Member

krobelus commented Dec 11, 2021

thanks, I only added the PR number to the changelog to simplify our paperwork

@krobelus krobelus merged commit 3b7994d into fish-shell:master Dec 11, 2021
@andmis andmis deleted the nodeenv-completions branch December 11, 2021 16:24
@krobelus krobelus added this to the fish 3.4.0 milestone Dec 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants