Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__fish_complete_proc results not usable by pkill/killall #8671

Open
floam opened this issue Jan 28, 2022 · 2 comments
Open

__fish_complete_proc results not usable by pkill/killall #8671

floam opened this issue Jan 28, 2022 · 2 comments
Labels
bug Something that's not working as intended completions
Milestone

Comments

@floam
Copy link
Member

floam commented Jan 28, 2022

__fish_complete_proc prints results like -fish for login shells with their argv[0] mutated for execve by login, or sh for e.g. /bin/bash executed through a symlink. killall, prep, etc do not work on these.

Screen Shot 2022-01-28 at 6 35 47 AM

Screen Shot 2022-01-28 at 6 36 21 AM

@floam floam added bug Something that's not working as intended completions labels Jan 28, 2022
@floam
Copy link
Member Author

floam commented Jan 28, 2022

At least on macOS, the fix is doing __fish_ps -o ucomm= instead of __fish_ps -o comm=. I don't know the story on Linux or other unixes.

image

@floam
Copy link
Member Author

floam commented Jan 28, 2022

, the fix is doing __fish_ps -o ucomm= instead of __fish_ps -o comm=. I

… Except for the processes which are truncated in the ucomm flavor output. com.apple.audio.SandboxHelper is printed as com.apple.audio. and com.apple.WebKit.WebContent as com.apple.WebKit- they don't work as killall arguments.

@zanchey zanchey added this to the fish-future milestone Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that's not working as intended completions
Projects
None yet
Development

No branches or pull requests

2 participants