Redraw pager on new selection when nothing was selected previously #9833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great - thank you! This is quite the fix especially for a first-time contributor. Amazing! |
|
Congratulations! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An attempt to solve the issue described in #9812.
With this change the
select_next_completion_in_directionfunction will no longer return early in the case when nothing was previously selected. The early return would skip updating thesuggested_row_startvariable, leading to the pager not scrolling down to show the new selection when using the "Up" arrow to wrap to the last item.This change seems to solve the issue based on manual testing.
Please let me know if anything under "TODO" should be updated.
Fixes issue #9812
TODOs: