Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completions for dnf5 #9862

Open
mochaaP opened this issue Jun 26, 2023 · 5 comments
Open

Completions for dnf5 #9862

mochaaP opened this issue Jun 26, 2023 · 5 comments

Comments

@mochaaP
Copy link

mochaaP commented Jun 26, 2023

https://fedoraproject.org/wiki/Changes/ReplaceDnfWithDnf5

DNF5 just landed in Fedora rawhide and provides the dnf command by default.
Since DNF5 is built on libdnf5 and introduced many changes, it should now be a good time to start providing completions for the dnf5 command.

@faho
Copy link
Member

faho commented Jun 26, 2023

According to https://dnf5.readthedocs.io/en/latest/changes.html#changes-on-the-command-line it's mostly a removal of unused features.

That means it shouldn't really impact us much, for now - we can't really remove the old syntax until nobody uses it anymore (i.e. until only Fedora versions with dnf5 are still supported).

@mochaaP
Copy link
Author

mochaaP commented Jun 26, 2023

We could provide a dnf5.fish though. This won't break the original dnf, while providing a more updated completion for dnf5 users.

@faho
Copy link
Member

faho commented Jun 26, 2023

It won't be of much use - people will keep using dnf <TAB>.

@mochaaP
Copy link
Author

mochaaP commented Jun 26, 2023

Vendors could ship an config file with alias dnf=dnf5 if dnf5 was the default provider for /usr/bin/dnf

@faho
Copy link
Member

faho commented Jun 26, 2023

They won't. They'll ship a symlink.

Vendors do not tend to configure fish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants