Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: env/exec completion includes fish functions #9897

Open
ilyagr opened this issue Jul 16, 2023 · 0 comments
Open

Minor: env/exec completion includes fish functions #9897

ilyagr opened this issue Jul 16, 2023 · 0 comments
Labels
bug Something that's not working as intended completions
Milestone

Comments

@ilyagr
Copy link
Contributor

ilyagr commented Jul 16, 2023

I'm using fish 3.6.1 (from the SUSE repo as recommended in fishshell.com) on Debian testing. It happens even if I run fish with sh -c 'env HOME=$(mktemp -d) fish'.

If I enter env funce<tab>, it completes to env funced. However, env funced does not work since funced is a fish function, not an external command.

The same thing happens with exec.

I think that both env and exec should ideally only complete actual external commands, not fish functions.


It is possible that some people are relying on this bug. For example, something like the following would work better with this bug present than without it:

function k --wraps=exec
  EDITOR=kak $argv
end

As @zanchey pointed out on Gitter, this usecase would probably be best served by abbreviations.

@zanchey zanchey added this to the fish-future milestone Jul 17, 2023
@zanchey zanchey added completions bug Something that's not working as intended labels Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that's not working as intended completions
Projects
None yet
Development

No branches or pull requests

2 participants