Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Krita completions #9903

Merged
merged 15 commits into from Jul 27, 2023

Conversation

EmilyGraceSeville7cf
Copy link
Contributor

@EmilyGraceSeville7cf EmilyGraceSeville7cf commented Jul 20, 2023

Description

Support Krita CLI.

Fixes issue #

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

@EmilyGraceSeville7cf EmilyGraceSeville7cf marked this pull request as draft July 20, 2023 17:02
@EmilyGraceSeville7cf EmilyGraceSeville7cf marked this pull request as ready for review July 20, 2023 17:37
@EmilyGraceSeville7cf
Copy link
Contributor Author

EmilyGraceSeville7cf commented Jul 23, 2023

I am not sure but if I manage it to implement dynamic suggestions for currently available workspaces (--workspace option), I provide such feature (but in the next PR).

UPD: Just done.

@faho faho changed the title Feature: support Krita Add Krita completions Jul 23, 2023
share/completions/krita.fish Outdated Show resolved Hide resolved
share/completions/krita.fish Outdated Show resolved Hide resolved
share/completions/krita.fish Outdated Show resolved Hide resolved
@faho faho mentioned this pull request Jul 23, 2023
3 tasks
share/completions/krita.fish Outdated Show resolved Hide resolved
share/completions/krita.fish Outdated Show resolved Hide resolved
share/completions/krita.fish Outdated Show resolved Hide resolved
share/completions/krita.fish Outdated Show resolved Hide resolved
@faho faho merged commit 6ce2ffb into fish-shell:master Jul 27, 2023
6 of 7 checks passed
@faho
Copy link
Member

faho commented Jul 27, 2023

Merged, thanks!

@faho faho added this to the fish 3.6.2 milestone Jul 27, 2023
faho pushed a commit that referenced this pull request Oct 6, 2023
* feat(completions): support Krita

* feat(completions): support summary options for Krita

* feat(completions): support remaining options for Krita

* feat(completions): remove debug instructions

* feat(completions): hide completions for sizes for Krita

* feat(completions): fix Krita

* feat(changelog): mention new completion

* fix(completions): refactor Krita

* fix(completion): reformat

* feat(completion): dynamically generate workspace list

* fix(completion): refactor

* fix(completion): krita

* fix(completions): use printf

(cherry picked from commit 6ce2ffb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants