scripting.png image is confusing

[krader1961]

The example at assets/img/screenshots/scripting.png should be updated to be clearer. See fish-shell/fish-shell#3832 for an example of how that image confused a user.

[krader1961]

It would probably be sufficient to begin the example with cd ~/.config/fish/functions to make it clear that the script containing the function is expected to be in the users function autoload directory.

[ridiculousfish]

I think I want to make this into a function rather than a call to cat.

[krader1961]

Presumably by "make this into a function rather than a call to cat" you mean to replace the cat detect_os.fish with something like function detect_os...end. That is, show how to interactively define such a function. But if we're going to do that it might be better to change the example implementation to something that better illustrates how fish differs from bash, et. al., when expanding vars rather than focusing on a function definition.

[ridiculousfish]

I'd love to show how the quoting nonsense isn't necessary, but I'm not sure how best to do that with a screenshot. Anyways I'm game - do you have an idea for what to show?

[faho]

Fixed by 456a04f.

[krader1961]

Thanks, @faho. Your rewrite neatly sidesteps the issues that were confusing our newest member of the fish community.

[faho]

Look again - @ridiculousfish made that 😆.

[ridiculousfish]

Happy it's krader approved 👍