Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added instruction to install fish on NixOS #53

Merged
merged 1 commit into from Oct 22, 2017
Merged

Added instruction to install fish on NixOS #53

merged 1 commit into from Oct 22, 2017

Conversation

ghost
Copy link

@ghost ghost commented Oct 14, 2017

Tried to keep the aspect ration for the lower row of icons, not sure if the added icon is not too big. Waiting for feedback

@floam
Copy link
Member

floam commented Oct 14, 2017

I believe the way you are linking to the asset on GitHub with the hash means it will forever only link to a specific revision. Might this be better?

https://github.com/NixOS/nixpkgs/blob/master/pkgs/shells/fish/default.nix

(I could be confused.)

@ghost
Copy link
Author

ghost commented Oct 14, 2017

@floam of course you're right! Will fix it soon

@ghost
Copy link
Author

ghost commented Oct 14, 2017

@floam I would like to tweak the logo size also, may I add some CSS for that, or it would be better if I had tweaked it in some graphical software?

@floam
Copy link
Member

floam commented Oct 14, 2017

Assuming you have access to a high resolution/scalable original, it is going to look best if you use Photoshop or whatever tool to size the image to the exact size you want so that browsers do not scale it. (If you're feeling cool, provide the image at 2x the desired width and height and just use width="x" height="y" on the img tag with the final rendered size so that on high resolution "retina" displays there's a bit of extra clarity.)

But even if you don't adjust the image, just do it on the img tag, no need for CSS.

@ridiculousfish
Copy link
Member

Should be fine to set the size of the image in the img tag. I'll pngcrush or whatever the image to make it smaller.

@ghost
Copy link
Author

ghost commented Oct 14, 2017

@floam @ridiculousfish I did some PNG optimizations, forgot ofc about imgrc, srcset, etc. By tweaking I meant adding some border either in the image alone or in the CSS to 'contain' that image more in the center (cause now it looks much overgrown compared to others).

obraz

@floam
Copy link
Member

floam commented Oct 14, 2017

If it doesn't offend the Nix people, that image might fit in better with the logo centered above and the "NixOS" text below. Otherwise I'd probably just add some transparent margin to the PNG to make it fit better rather than tweak it in CSS for the sake of keeping this contained.

@ridiculousfish
Copy link
Member

Yeah that does look out of place. I also agree with floam's observation that it would look more consistent if it were oriented vertically instead of horizontally.

@ghost
Copy link
Author

ghost commented Oct 15, 2017

@floam @ridiculousfish Thanks to work of @wmertens, I added the square version of the logo.

obraz

@floam
Copy link
Member

floam commented Oct 15, 2017

Since that guy made a SVG we could probably just use that directly, they are well supported these days.

@ghost
Copy link
Author

ghost commented Oct 15, 2017

@floam changed

@ghost
Copy link
Author

ghost commented Oct 22, 2017

@floam ready to merge (?)

@floam floam merged commit f409fef into fish-shell:master Oct 22, 2017
@ridiculousfish
Copy link
Member

Updated the site

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants