New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added instruction to install fish on NixOS #53
Conversation
I believe the way you are linking to the asset on GitHub with the hash means it will forever only link to a specific revision. Might this be better?
(I could be confused.) |
@floam of course you're right! Will fix it soon |
@floam I would like to tweak the logo size also, may I add some CSS for that, or it would be better if I had tweaked it in some graphical software? |
Assuming you have access to a high resolution/scalable original, it is going to look best if you use Photoshop or whatever tool to size the image to the exact size you want so that browsers do not scale it. (If you're feeling cool, provide the image at 2x the desired width and height and just use But even if you don't adjust the image, just do it on the |
Should be fine to set the size of the image in the |
@floam @ridiculousfish I did some PNG optimizations, forgot ofc about imgrc, srcset, |
If it doesn't offend the Nix people, that image might fit in better with the logo centered above and the "NixOS" text below. Otherwise I'd probably just add some transparent margin to the PNG to make it fit better rather than tweak it in CSS for the sake of keeping this contained. |
Yeah that does look out of place. I also agree with floam's observation that it would look more consistent if it were oriented vertically instead of horizontally. |
@floam @ridiculousfish Thanks to work of @wmertens, I added the square version of the logo. |
Since that guy made a SVG we could probably just use that directly, they are well supported these days. |
@floam changed |
@floam ready to merge (?) |
Updated the site |
Tried to keep the aspect ration for the lower row of icons, not sure if the added icon is not too big. Waiting for feedback