Skip to content

Commit

Permalink
Fix: #3523 - ImageMagick sometimes fails to detect image quality
Browse files Browse the repository at this point in the history
  • Loading branch information
fisharebest committed Sep 28, 2020
1 parent 74a95fc commit bf26501
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/Factories/ImageFactory.php
Expand Up @@ -421,7 +421,7 @@ protected function extractImageQuality(Image $image, int $default): int
$core = $image->getCore();

if ($core instanceof Imagick) {
return $core->getImageCompressionQuality();
return $core->getImageCompressionQuality() ?: $default;
}

return $default;
Expand Down

2 comments on commit bf26501

@ddrury
Copy link
Contributor

@ddrury ddrury commented on bf26501 Oct 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest demo. Thumbnail as referenced above still looks ropey. Maybe need to regenerate it? BTW media items M91 & M103 return 404 response

@fisharebest
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe need to regenerate it?

I just deleted the cache, and it looks fine now.

I'll look at the 404s later

Please sign in to comment.