Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Individual Places map markers - 2.0.0 #1805

Closed
melizaa opened this issue Jul 22, 2018 · 7 comments
Closed

Individual Places map markers - 2.0.0 #1805

melizaa opened this issue Jul 22, 2018 · 7 comments

Comments

@melizaa
Copy link
Contributor

melizaa commented Jul 22, 2018

How can one show a death/burial marker that does not look like a cross?
For instance a grave without a cross:
2018-07-22_23-51-34

@ddrury
Copy link
Contributor

ddrury commented Jul 24, 2018

The marker icons are taken from the Font Awesome collection, if you can find anything here that is more appropriate then let us know and we'll probably use it.

@melizaa
Copy link
Contributor Author

melizaa commented Aug 11, 2018

How can I replace Font Awesome icons by own icons?

@ddrury
Copy link
Contributor

ddrury commented Aug 12, 2018

Not easy at the moment! The fontawesome icon is defined in app/factlocation.php::getIconDetails and the markup is created in javascript but I don't know where that is to be found since Greg's restructure.
Perhaps we could create the icons in views - Greg, what do you think?

@ddrury
Copy link
Contributor

ddrury commented Aug 13, 2018

How about the fontawesome icon for either Church or Monument (my preference) - I realise that neither are ideal but maybe better than the current choice

@fisharebest
Copy link
Owner

...or maybe just lose the beautifymarker/font-awesome icons, and use the default leafletjs map markers?

@fisharebest
Copy link
Owner

fisharebest commented Aug 18, 2018

There are some fairly "standard" symbols used in genealogy.

See:
https://www.tamurajones.net/GenealogySymbols.xhtml
http://wiki-en.genealogy.net/Symbols_and_Signs
https://www.geni.com/projects/Abbreviations-Acronyms-for-Genealogy-The-Accepted/3096

Birth: asterisk *
Baptism: tilde ~
Death: plus or dagger + or
Burial: square brackets []

I'm going to put this issue on hold for a while and come back to it later.

@fisharebest
Copy link
Owner

fisharebest commented May 11, 2019

I have updated the icons with more neutral options. e.g.

  • death - a diagonal cross (as used for "close" elsewhere on the site).
  • marriage - a double-circle, instead of male+female symbol.

They are defined in app/Module/PlacesModule.php.

To suggest an new / different icon/color, raise another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants