Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in the statistics distribution diagram, transferring string… #3537

Merged
merged 1 commit into from Jan 8, 2021

Conversation

magicsunday
Copy link
Contributor

… values instead of integers

@codecov
Copy link

codecov bot commented Oct 10, 2020

Codecov Report

Merging #3537 (9b64441) into master (8b2d6d9) will decrease coverage by 0.57%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3537      +/-   ##
============================================
- Coverage     22.62%   22.04%   -0.58%     
+ Complexity    11664    11640      -24     
============================================
  Files           938      938              
  Lines         41656    41608      -48     
============================================
- Hits           9425     9173     -252     
- Misses        32231    32435     +204     
Impacted Files Coverage Δ Complexity Δ
app/Statistics/Google/ChartDistribution.php 45.83% <50.00%> (ø) 36.00 <0.00> (ø)
app/Module/IndividualListModule.php 0.00% <0.00%> (-62.81%) 139.00% <0.00%> (ø%)
app/Module/ModuleListTrait.php 0.00% <0.00%> (-54.55%) 8.00% <0.00%> (ø%)
app/Census/CensusColumnFullName.php 53.33% <0.00%> (-46.67%) 10.00% <0.00%> (+9.00%) ⬇️
app/Report/AbstractRenderer.php 94.11% <0.00%> (-5.89%) 7.00% <0.00%> (+1.00%) ⬇️
app/Statistics/Repository/UserRepository.php 49.38% <0.00%> (-1.26%) 43.00% <0.00%> (+1.00%) ⬇️
app/MediaFile.php 0.00% <0.00%> (ø) 38.00% <0.00%> (ø%)
app/Individual.php 0.00% <0.00%> (ø) 201.00% <0.00%> (ø%)
app/Date/JewishDate.php 0.00% <0.00%> (ø) 28.00% <0.00%> (ø%)
app/Module/AlbumModule.php 0.00% <0.00%> (ø) 9.00% <0.00%> (+1.00%)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b2d6d9...95b3ac4. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.886% when pulling 9b64441 on magicsunday:chart into 4aa632f on fisharebest:master.

@magicsunday
Copy link
Contributor Author

Hi @fisharebest, could you please take a look at this small fix?

@fisharebest
Copy link
Owner

Do you think it would be better to modify function statsPlaces() to return an int?

@magicsunday
Copy link
Contributor Author

I changed the statsPlaces method to return integer values.

@fisharebest fisharebest merged commit 936d28c into fisharebest:master Jan 8, 2021
@fisharebest
Copy link
Owner

Looks good. Thanks!

@magicsunday magicsunday deleted the chart branch January 9, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants