Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 3 Canadian Census years #3897

Merged
merged 7 commits into from May 18, 2021
Merged

Adding 3 Canadian Census years #3897

merged 7 commits into from May 18, 2021

Conversation

glarwill
Copy link
Contributor

Uncertain about my ordering of the various censuses based upon locale.

@coveralls
Copy link

coveralls commented May 17, 2021

Coverage Status

Coverage increased (+0.1%) to 22.395% when pulling c9ba443 on glarwill:main into 2aeda30 on fisharebest:main.

@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #3897 (c9ba443) into main (2aeda30) will increase coverage by 0.14%.
The diff coverage is 90.09%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3897      +/-   ##
============================================
+ Coverage     23.73%   23.87%   +0.14%     
- Complexity    11203    11213      +10     
============================================
  Files          1587     1592       +5     
  Lines         47734    47835     +101     
============================================
+ Hits          11331    11422      +91     
- Misses        36403    36413      +10     
Impacted Files Coverage Δ Complexity Δ
app/Census/CensusColumnBirthMonthDay.php 0.00% <0.00%> (ø) 1.00 <1.00> (?)
app/Census/CensusOfCanada.php 0.00% <0.00%> (ø) 3.00 <3.00> (?)
app/Census/Census.php 100.00% <100.00%> (ø) 11.00 <0.00> (ø)
app/Census/CensusOfCanada1881.php 100.00% <100.00%> (ø) 2.00 <2.00> (?)
app/Census/CensusOfCanada1891.php 100.00% <100.00%> (ø) 2.00 <2.00> (?)
app/Census/CensusOfCanada1901.php 100.00% <100.00%> (ø) 2.00 <2.00> (?)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aeda30...c9ba443. Read the comment docs.

@fisharebest fisharebest merged commit 53a83c5 into fisharebest:main May 18, 2021
@fisharebest
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants