Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Census assistant - Use markdown unordered lists for plain text census elements #4115

Closed
wants to merge 1 commit into from

Conversation

ddrury
Copy link
Contributor

@ddrury ddrury commented Nov 12, 2021

Rather than use markdown paragraph or line breaks, convert plain text paragraphs into an unordered list that can be styled by css

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #4115 (ee4dddb) into main (58bab7f) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #4115      +/-   ##
============================================
- Coverage     25.69%   25.68%   -0.01%     
- Complexity    11175    11176       +1     
============================================
  Files          1608     1608              
  Lines         48459    48463       +4     
============================================
  Hits          12450    12450              
- Misses        36009    36013       +4     
Impacted Files Coverage Δ
app/Functions/FunctionsPrint.php 0.00% <0.00%> (ø)
app/Module/CensusAssistantModule.php 0.00% <0.00%> (ø)
app/Note.php 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58bab7f...ee4dddb. Read the comment docs.

@ddrury ddrury changed the title Use markdown unordered lists for plain text census elements Census assistant - Use markdown unordered lists for plain text census elements Nov 12, 2021
@ddrury ddrury mentioned this pull request Nov 23, 2021
@ddrury
Copy link
Contributor Author

ddrury commented Nov 29, 2021

Rewriting so that all note formatting is handled on display, and tree preference 'FORMAT_TEXT' is always obeyed.

@ddrury ddrury closed this Nov 29, 2021
@ddrury ddrury deleted the Census_assistant_note_html branch November 29, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant