Format notes on display rather than by adding formatting on creation. #4128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4128 +/- ##
============================================
- Coverage 25.87% 25.86% -0.02%
- Complexity 11174 11178 +4
============================================
Files 1573 1574 +1
Lines 48219 48240 +21
============================================
Hits 12479 12479
- Misses 35740 35761 +21
Continue to review full report at Codecov.
|
ddrury
force-pushed
the
Format_note_on_display
branch
3 times, most recently
from
5aaa9c7
to
518ffae
Compare
|
BTW, I did think of shifting the view from Functions::printNoteRecord into app/Note::getHtml and by doing so it would make it simple to do away with Functions::printNoteRecord altogether, but it would make app/Note::getHtml quite a lot bigger and I didn't think it was really appropriate for the Note class |
Closed
ddrury
force-pushed
the
Format_note_on_display
branch
from
518ffae
to
4924f1e
Compare
Improve regex table detection Fix change committed in error - Note::getNote() bug fix - function printMainNotes extracting too much text in some cases
ddrury
force-pushed
the
Format_note_on_display
branch
from
4924f1e
to
f6850e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #4123 (I think)
To achieve this:
Because the formatting code is in the Note class, it is necessary to convert in-line notes into temporary dummy note objects so the same code can be used for all notes.
<p></p>and tables are wrapped in<div></div>which allows styling if needed.Note: some changes have involved classes FunctionsPrint & FunctionsPrintFact that have been slated for removal in 2.1