Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format markdown text on display #4135

Closed
wants to merge 1 commit into from

Conversation

ddrury
Copy link
Contributor

@ddrury ddrury commented Dec 7, 2021

Better (and simpler) attempt at solving issue #4123

To achieve this:

  • Recent changes to the census assistant have been reverted (this obviates the need for retrospective changes to existing notes)
  • Added two trailing spaces to html in abstractElement::valueFormatted()
  • Whenever some formatted text is needed used code similar to this
$element = new SubmitterText('');
$formatted = $element->value($text, $tree);

@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #4135 (269bc4c) into main (cc4c83a) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #4135   +/-   ##
=========================================
  Coverage     25.87%   25.87%           
  Complexity    11175    11175           
=========================================
  Files          1573     1573           
  Lines         48225    48225           
=========================================
  Hits          12479    12479           
  Misses        35746    35746           
Impacted Files Coverage Δ
app/Elements/AbstractElement.php 73.83% <0.00%> (-0.70%) ⬇️
app/Functions/FunctionsPrint.php 0.00% <0.00%> (ø)
app/Http/RequestHandlers/ManageMediaData.php 22.78% <0.00%> (ø)
app/Http/RequestHandlers/NotePage.php 0.00% <ø> (ø)
app/Media.php 0.00% <0.00%> (ø)
app/Module/CensusAssistantModule.php 0.00% <0.00%> (ø)
resources/views/note-page-details.phtml 0.00% <0.00%> (ø)
resources/views/note-page.phtml 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc4c83a...269bc4c. Read the comment docs.

@ddrury ddrury changed the title Format text on display Format markdown text on display Dec 8, 2021
@ddrury ddrury closed this Dec 20, 2021
@ddrury ddrury deleted the format_note_on_display_2 branch January 28, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant