Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate exception when no map providers enabled #4166

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

ddrury
Copy link
Contributor

@ddrury ddrury commented Jan 19, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #4166 (152fc23) into main (648a131) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #4166      +/-   ##
============================================
- Coverage     31.68%   31.68%   -0.01%     
- Complexity    11221    11222       +1     
============================================
  Files          1090     1090              
  Lines         40851    40853       +2     
============================================
  Hits          12945    12945              
- Misses        27906    27908       +2     
Impacted Files Coverage Δ
app/Services/LeafletJsService.php 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 648a131...152fc23. Read the comment docs.

@ddrury ddrury force-pushed the Exception_on_no_map_providers branch from bd8cff9 to 152fc23 Compare January 19, 2022 11:40
@fisharebest
Copy link
Owner

I see a page-within-a-page.

I guess something isn't setting the header X-Requested-With`, so the exception handler doesn't know it is responding to an ajax request. Let me investigate...

Screenshot 2022-01-28 at 19 34 43

fisharebest added a commit that referenced this pull request Jan 28, 2022
@fisharebest fisharebest merged commit 94c9068 into fisharebest:main Jan 28, 2022
ddrury pushed a commit to ddrury/webtrees that referenced this pull request Jan 31, 2022
ddrury added a commit to ddrury/webtrees that referenced this pull request Jan 31, 2022
@ddrury ddrury deleted the Exception_on_no_map_providers branch January 31, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants