consolidate map size css #4808
Merged
consolidate map size css #4808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4808 +/- ##
=========================================
Coverage 30.95% 30.95%
Complexity 11372 11372
=========================================
Files 1167 1167
Lines 47861 47861
=========================================
Hits 14813 14813
Misses 33048 33048 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ddrury
changed the title
fisharebest
reviewed
Apr 19, 2023
|
|
||
| <div class="col-sm-3"> | ||
| <div class="col-sm-3 wt-sidebar wt-global"> |
There was a problem hiding this comment.
We use wt-global on the body element (because it is generallly better to target classes than elements).
I don't think we should use it elsewhere.
There was a problem hiding this comment.
Ok but without it the sidebar background becomes black so I'll have to add the admin background image to another class
There was a problem hiding this comment.
We use wt-global on the body element
Fixed
ddrury
force-pushed
the
Consolidate_map_css
branch
2 times, most recently
from
a61108b
to
a55f0ec
Compare
ddrury
force-pushed
the
Consolidate_map_css
branch
from
a55f0ec
to
6c77a7e
Compare
|
Thanks! |
fisharebest
pushed a commit
that referenced
this pull request
Apr 21, 2023
* consolidate map size css into one file (/resources/css/_maps.css) * Remove use of wt-global for sidebar background * Adjust class names and use ::backdrop pseudo class for all themes
ddrury
added a commit
to ddrury/webtrees
that referenced
this pull request
Jul 16, 2023
* consolidate map size css into one file (/resources/css/_maps.css) * Remove use of wt-global for sidebar background * Adjust class names and use ::backdrop pseudo class for all themes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge all into one file - renamed /resources/css/_leaflet.css to /resources/css/_maps.css