-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wrapping behaviour to the fact note. #4987
base: main
Are you sure you want to change the base?
Conversation
Issue: When you add long url to the fact note it overflows the container. I resolved it by adding overflow-wrap: break-word to the .wt-facts-table td .wt-fact-notes p
We have a CSS class Would it be better to add this class to the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4987 +/- ##
=========================================
Coverage 33.78% 33.78%
Complexity 11405 11405
=========================================
Files 1177 1177
Lines 47514 47514
=========================================
Hits 16053 16053
Misses 31461 31461 ☔ View full report in Codecov by Sentry. |
Good idea |
I am away for a few days. If you need help finding this, ask me next week. |
This reverts commit af8a756.
Class applies overflow-wrap: break-word and unicode-bidi: isolate to the element
I found it already. Now it should work fine. |
Issue: When you add long url to the fact note it overflows the container.
I resolved it by adding overflow-wrap: break-word to the .wt-facts-table td .wt-fact-notes p