Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wrapping behaviour to the fact note. #4987

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

p-litwin
Copy link

Issue: When you add long url to the fact note it overflows the container.
I resolved it by adding overflow-wrap: break-word to the .wt-facts-table td .wt-fact-notes p

Issue: When you add long url to the fact note it overflows the container.
I resolved it by adding overflow-wrap: break-word to the .wt-facts-table td .wt-fact-notes p
@fisharebest
Copy link
Owner

We have a CSS class ut (user-generated text) which provides this functionality.

Would it be better to add this class to the p element? This is (possibly) in NoteStructure.php...

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.78%. Comparing base (326ac7e) to head (af8a756).

Current head af8a756 differs from pull request most recent head d986e46

Please upload reports for the commit d986e46 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4987   +/-   ##
=========================================
  Coverage     33.78%   33.78%           
  Complexity    11405    11405           
=========================================
  Files          1177     1177           
  Lines         47514    47514           
=========================================
  Hits          16053    16053           
  Misses        31461    31461           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@p-litwin
Copy link
Author

We have a CSS class ut (user-generated text) which provides this functionality.

Would it be better to add this class to the p element? This is (possibly) in NoteStructure.php...

Good idea
For one line inline note it's already there, but multiline note is formatted elsewhere. I didn't locate it yet. I'll check this later.

@fisharebest
Copy link
Owner

I didn't locate it yet. I'll check this later.

I am away for a few days. If you need help finding this, ask me next week.

Class applies overflow-wrap: break-word and unicode-bidi: isolate to the element
@p-litwin
Copy link
Author

I didn't locate it yet. I'll check this later.

I am away for a few days. If you need help finding this, ask me next week.

I found it already. Now it should work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants