Javascript modal dialog changes #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've just discovered another problem which this fixes, currently if alternating calls are made to modalDialog followed by helpDialog, then the overlays build up and the only way to clear them is to reload the page |
|
I've done it again!! clicked the wrong button |
1. Use JSON to call help_text.php.
2. New function(displayDialog() to create and display a modal dialog and
modify modalDialog(), helpDialog() & modalNotes to call it (provides
consistent functioning)
3. New function modalConfirm replaces native confirm dialog
usage: modalConfirm(title,text).then(function (reply) {...};
|
Withdrawn - causes problem if ckeditor instance itself opens a dialog (caused by setting modal=true) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses JSON to call help_text.php.
The diff display makes it difficult to see what I've done, but I've modified modalDialog(), helpDialog() & modalNotes to use jQuery to create a DIV element with title & html attributes populated by whatever call method is appropriate and then pass that element to a new function displayDialog() which instantiates and displays the dialog and handles clicking on the overlay and tidyup on close (which at least one of the old functions didn't - can't remember which off hand)