#1269075 - Names containing an apostrophe (') are displayed as Name (Nam... #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Jon - I fixed this before I saw this pull request. But I made a nearly identicat change. I compared two unescaped values, rather than two escaped ones. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug #1269075
The
$namevariable is compared to the surname extracted for the individual, to decide whether or not to display the potential different surname in brackets.However;
$namegoes through theWT_Filter::escapeHtmlfilter whereas$primary_name['surname']does not, which is a problem when comparing a special character with its equivalent HTML (for instance the quote ')