Make $translation_adapter public so it can be used by custom modules to add their own translations

[JustCarmen]

Since Zend_Registry::get('Zend_Translate') is deprecated, a work around is to use parent::__construct() in the module constructor.

But if you make the WT_I18N variabele $translation_adapter public then this adapter can be used by custom modules to add their own translations and isn't it necessary to keep the deprecated function alive.

A custom translation then can be implemented in the module constructor in this way:

WT_I18N::$translation_adapter->addTranslation(
        new Zend_Translate('gettext', WT_MODULES_DIR.$this->getName().'/language/'.WT_LOCALE.'.mo', WT_LOCALE)
);

[JustCarmen]

I just found out that the code is working in front without parent:: _ construct, but not in the backend. So to use this code in a custom module the module constructor must start wit parent:: _ construct(). After that the translation files can be called with WT_I18N::$translation_adapter->addTranslation();

[fisharebest]

Do you think it is right to remove Zend_Registry::set() ?

It is removed in ZF2, but are there other custom modules that use it? IIRC, there are some ZF1 functions that use it.

I have another suggestion. Add this to WT_I18N

public static function addTranslation(Zend_Translate $translation) {
    WT_I18N::$translation_adapter->addTranslation($translation);
}

We initialise WT_I18N before we initialise the modules, so any module should be able to call this at any time. e.g.

public function __construct() {
    parent::__construct();
    WT_I18N::addTranslation(
        new Zend_Translate('gettext', '/path/to/module/language/'.WT_LOCALE.'.mo', WT_LOCALE)
    );
}

[fisharebest]

I've just tested this in a module, and it seems to work fine for me, so I have commited the change.

Let me know if it works for you.

[JustCarmen]

Yes this works just fine. Thanks.