Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow matchmaker to configure Iroh secret key for stable nodeID #405

Closed
MaxCWhitehead opened this issue May 18, 2024 · 1 comment · Fixed by #406
Closed

Allow matchmaker to configure Iroh secret key for stable nodeID #405

MaxCWhitehead opened this issue May 18, 2024 · 1 comment · Fixed by #406

Comments

@MaxCWhitehead
Copy link
Collaborator

nodeID is derived from secret key which is currently randomly generated. Each time matchmaker restarts it will get a new node id, making it difficult to share a stable node ID (address for connection).

Couple of thoughts:

  1. Could generate secret if not provided and save to a file (which would be some mounted volume on container, would need a write-able local path if non-containerized which is slightly more annoying).
  2. Allow secret key (ed2515119) to be specified as env var, generate if none, otherwise use env.

I think two sounds slightly simpler / probably good enough.
@zicklag
Copy link
Member

zicklag commented May 18, 2024

Yeah, I think option 2 is good. 👍

dignifiedquire added a commit to dignifiedquire/bones that referenced this issue May 18, 2024
@dignifiedquire
feat: add option to supply fixed secret key to the matchmaker
e31e04a 
Key can be passed in via `BONES_MATCHMAKER_SECRET_KEY`

Closes fishfolk#405
@dignifiedquire dignifiedquire mentioned this issue May 18, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 18, 2024
@dignifiedquire
feat: add option to supply fixed secret key to the matchmaker (#406)
8240aea 
Key can be passed in via `BONES_MATCHMAKER_SECRET_KEY`

To show the secret key when generating, you can pass
`--print-secret-key` to the binary now

Closes #405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add option to supply fixed secret key to the matchmaker dignifiedquire/bones
2 participants
@zicklag @MaxCWhitehead