fix(networking): Switch to ggrs fork with fix for corrections dropped at max prediction #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
at max prediction
|
The CI failures are due to a change made yesterday in nightly rust - proceeding with merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching to fork of ggrs with some fixes I am testing for desync. Desync occurs when client receives a frame it should rollback and correct while also at max prediction threshold (requires 3+ clients to hit failure, as if only 2 after receiving remote input 2nd would not be at max prediction anymore).
Changes being used are here: https://github.com/MaxCWhitehead/ggrs/tree/prediction-error-rollback-test
So far I no longer reproduce desync in jumpy, and the test I implemented in that branch is now passing.