feat: remove MAX_PLAYER limit for networked games #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dignifiedquire Change here looks good, thank you! I expect this will break compilation of jumpy due to API changes. Usually when making changes to bones that will break dependents (just Jumpy atm) will open a PR on jumpy too with relevant adjustments so if update bones version in cargo.lock won't have extra stuff to chase down to get it running. |
dignifiedquire
force-pushed
the
feat-remove-player-limit
branch
from
523979f
to
c343d98
Compare
MaxCWhitehead
added a commit
to fishfolk/jumpy
that referenced
this pull request
Jul 4, 2024
matching PR to fishfolk/bones#407 --------- Co-authored-by: Max Whitehead <max.blackllama.alt3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naive pass at removing the max player limit. I haven't thought all parts through, but putting this here for a first round of feedback.
Closes #298