Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: reorganize bones-bevy-renderer. #417

Merged
merged 19 commits into from
Jun 29, 2024

Conversation

zicklag
Copy link
Member

@zicklag zicklag commented Jun 21, 2024

Submitting on behalf of @tekhaeraav:

This is a reorganization of bones-bevy-renderer that cleans up some dead code and attempts to make the renderer easier to understand without making any breaking changes.

@zicklag zicklag changed the title refactor: reorganize bones-bevy-renderer. refactor!: reorganize bones-bevy-renderer. Jun 21, 2024
Copy link
Member Author

@zicklag zicklag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be tested with Jumpy to make sure there's no regressions, but otherwise I approve ✅.

There's one added feature that lets you start the game without waiting for assets to load, in case you want to handle asset loading yourself ( a use-case in the Bones game maker UI @TekhnaeRaav is working on ).

The rest is minimally changed functionally, mostly re-organized.

Copy link
Collaborator

@MaxCWhitehead MaxCWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thank you @TekhnaeRaav!

@MaxCWhitehead
Copy link
Collaborator

Once get CI errors cleaned up + confirm works on jumpy can merge.

@MaxCWhitehead
Copy link
Collaborator

Seems to work with jumpy - just had to define the preload setting.

@MaxCWhitehead MaxCWhitehead merged commit 0d82737 into fishfolk:main Jun 29, 2024
9 of 10 checks passed
@zicklag zicklag deleted the tekhnaeraav-several-improvements branch June 29, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants