-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: reorganize bones-bevy-renderer. #417
refactor!: reorganize bones-bevy-renderer. #417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be tested with Jumpy to make sure there's no regressions, but otherwise I approve ✅.
There's one added feature that lets you start the game without waiting for assets to load, in case you want to handle asset loading yourself ( a use-case in the Bones game maker UI @TekhnaeRaav is working on ).
The rest is minimally changed functionally, mostly re-organized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great thank you @TekhnaeRaav!
Once get CI errors cleaned up + confirm works on jumpy can merge. |
Seems to work with jumpy - just had to define the preload setting. |
Submitting on behalf of @tekhaeraav:
This is a reorganization of bones-bevy-renderer that cleans up some dead code and attempts to make the renderer easier to understand without making any breaking changes.