Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: selectable keys for replace command #72

Closed
mattlqx opened this issue Feb 4, 2021 · 4 comments
Closed

Feature: selectable keys for replace command #72

mattlqx opened this issue Feb 4, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@mattlqx
Copy link
Collaborator

mattlqx commented Feb 4, 2021

While the replace command will be a powerful way to make changes to a Vault store, it may be difficult to limit replacements in cases where you only want to change a particular key across many paths.

For example, if you have the following Vault structure:

my/vault/path/a:
  first-key: weak-value
  second-key: strong-value
...
my/vault/path/z:
  first-key: strong-value
  second-key: weak-value

And you only want to change first-key's value from weak-value to strong-value, you can't presently do that with the replace command without also changing second-key's value. This is a contrived example, but most of the time, you will indeed want to limit changing values to a particular key.

@fishi0x01 fishi0x01 added the enhancement New feature or request label Feb 5, 2021
@fishi0x01
Copy link
Owner

I think the use-case you describe is quite common. That feature proposal is a great idea. I will give it a try on the weekend 👍

@mattlqx
Copy link
Collaborator Author

mattlqx commented Feb 5, 2021

I guess I'm trying to inform you what I'm up to by opening these. I already have it done, but was dependent on the prior PR. 🙂 I also did notice some bugs with regex matching that I'll fix soon too as well.

After that though, I think I can take a break. lol

@fishi0x01
Copy link
Owner

Haha ok. Well in that case, thanks again Matt. That is great news 🙇

@fishi0x01
Copy link
Owner

Fixed by #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants