FCE-205 Refactor into smaller files

[kamil-stasiak]

Description

Basic refactor:

• extract code to separate files

Motivation and Context

src/webrtc/webRTCEndpoint.ts is too big and has too many responsibilities. It's hard to work with it.

Types of changes

Refactor (non-breaking change)

[czerwiukk]

please extract this big boolean to a variable and use the variable in the condition, same can apply to the 95th line, sth like

const areThereOngoingOperations = ...
const isStateInvalid = ...
if(areThereOngoingOperations || isStateInvalid) return

[mironiasty]

Another approach could be to create separate function and call here as:

if(this.isConnectionActvite()) { ...

(maybe with better name?)

[kamil-stasiak]

I came up with something like this:

private isConnectionUnstable() {
    const connection = this.stateManager.connection;
    if (connection === undefined) return false;

    const isSignalingUnstable = connection.signalingState !== 'stable';
    const isConnectionNotConnected = connection.connectionState !== 'connected';
    const isIceNotConnected = connection.iceConnectionState !== 'connected';

    return isSignalingUnstable && isConnectionNotConnected && isIceNotConnected;
  }

  private isNegotiationInProgress() {
    return (
      this.negotiationManager.ongoingRenegotiation ||
      this.stateManager.ongoingTrackReplacement
    );
  }

  public processNextCommand() {
    if (this.isNegotiationInProgress()) return;
    if (this.isConnectionUnstable()) return;

    this.resolvePreviousCommand();

    const command = this.commandsQueue.shift();

    if (!command) return;

    this.commandResolutionNotifier = command.resolutionNotifier;
    this.handleCommand(command);
  }

[czerwiukk]

little to not important nit:
would you prefer early returns in general?

if (!this.CRN) return 
this.commandResolutionNotifier.resolve();
this.commandResolutionNotifier = null;

[mironiasty]

:50_50:
I usually prefer to avoid early returns, as they make code less readable. But this is subjective opinion.

[czerwiukk]

this fn could be broken down to smaller functions to increase readibility

[kamil-stasiak]

I agree. I will refactor it in the future PRs

[czerwiukk]

we mutate a map passed in as an argument and return a completely other value.
please create another function to handle updating the disabled encodings

i can see its being drilled through at least 3 functions, i still think it should get refactored though

[kamil-stasiak]

I will do it in future PRs

[linear]

FCE-205 Refactor ts-client code (split two main files into smaller pieces)

[mironiasty]

Another approach could be to create separate function and call here as:

if(this.isConnectionActvite()) { ...

(maybe with better name?)

[mironiasty]

This is something for separate PR. But I would vote to add a prettier rule to always use brackets. This will make expressions like this more readable.

Suggested change

	if (
	this.negotiationManager.ongoingRenegotiation ||
	this.stateManager.ongoingTrackReplacement
	)
	return;
	if (
	this.negotiationManager.ongoingRenegotiation ||
	this.stateManager.ongoingTrackReplacement
	) {
	return;
	}

[mironiasty]

:50_50:
I usually prefer to avoid early returns, as they make code less readable. But this is subjective opinion.

[mironiasty]

WDYT about having two functions renegotationStarted() and renegotationCompleted() with private variable?

[kamil-stasiak]

I agree. That's why I created this class. I will do it in future PRs

[mironiasty]

It would require a little more work, but in future refactor it would be nice to create filter functions that returns proper TS type, so no ! will be required.

[kamil-stasiak]

I will address the remaining comments (on the old code that I moved to other files) in future PRs. For now, I don't want to interfere too much with the logic. I would like to dedicate the next PR to cleaning up the state, which is currently spread across many fields is StateManager

[mironiasty]

TL;DR;