First version of SFU API #2

mickel8 · 2021-07-01T11:05:15Z

No description provided.

…rom MembraneWebRTC

functions

Signed-off-by: Austin Putman <austinp@geometer.io> Co-authored-by: Austin Putman <austinp@geometer.io>

mickel8 · 2021-07-09T11:33:22Z

I made a quick commit of some grammar/typo fixes in the Elixir docs. Here it is for review:

geometerio@2b806eb

Awesome! Cherry-picked

Today we began playing with :deny_new_peer, and realized that we wanted to pass data through to the client. Here is our quick implementation: geometerio@51c10cc

Because we're mounting our page using LiveView, we could handle this entirely in our application with Phoenix.PubSub. I feel like this feature (passthrough of data to the onDenial javascript callback) would be useful for others, though.

Good idea, this also is something that @mat-hek proposed in #2 (comment). Cherry-picked

I am also wondering if data is meaningful enough. Could it be reason or there might be some cases in which we want more general name like data?

mat-hek · 2021-07-15T16:36:06Z

assets/js/membraneWebRTC.ts

+      let mediaEvent = generateMediaEvent("join", {
+        relayAudio: relayAudio,
+        relayVideo: relayVideo,
+        receiveMedia: this.receiveMedia,
+        metadata: peerMetadata,
+        tracksMetadata: Array.from(this.localTrackIdToMetadata.values()),
+      });
+      this.callbacks.onSendMediaEvent(serializeMediaEvent(mediaEvent));


sendMediaEvent calling generateMediaEvent, serializeMediaEvent and onSendMediaEvent would be useful

mat-hek · 2021-07-15T16:40:47Z

assets/js/membraneWebRTC.ts

+
+  /**
+   * Leaves the room. This function should be called when user leaves the room
+   * in a clean way e.g. by clicking dedicated, custom button `dissconnetc`.


Suggested change

* in a clean way e.g. by clicking dedicated, custom button `dissconnetc`.

* in a clean way e.g. by clicking a dedicated, custom button `disconnect`.

mat-hek · 2021-07-16T09:07:31Z

lib/membrane_sfu/media_event.ex

+    case event do
+      %{"type" => "leave"} ->


you already check that in the header

mat-hek · 2021-07-16T09:17:17Z

lib/membrane_sfu/media_event.ex

@@ -88,7 +105,7 @@ defmodule Membrane.SFU.MediaEvent do
  end

  defp do_deserialize(%{"type" => "join"} = event) do


There will be a match error on an unknown event. We'd probably add a fallback clause returning an error.

mat-hek · 2021-07-16T09:24:38Z

lib/membrane_sfu_app.ex

@@ -0,0 +1,13 @@
+defmodule Membrane.SFUApp do


Suggested change

defmodule Membrane.SFUApp do

defmodule Membrane.SFU.App do

mat-hek · 2021-07-16T09:25:58Z

mix.exs

+
+  defp compile_ts(_) do
+    Mix.shell().info("Installing npm dependencies")
+    {result, exit_status} = System.cmd("npm", ["install"], cd: "assets")


This should rather be npm ci

package.json

sax · 2021-07-18T15:21:08Z

In reference to :deny_new_peer:

I am also wondering if data is meaningful enough. Could it be reason or there might be some cases in which we want more general name like data?

We were torn on this. I think either way is valid. data is more extensible—one could provide a message for the user, as well as extra metadata such as where to redirect a client to. reason might make the API tighter, but force integrators to move more logic into javascript.

mat-hek · 2021-07-19T09:38:17Z

@sax @mickel8 maybe metadata is the proper word?

…JoinError` respectively

FelonEkonom and others added 27 commits July 1, 2021 13:04

Generate participant id, when participant is joining room

a5b23f2

Set peer type on start message

ba24685

Send participant config in payload in start event

70f944b

Remove unnecesary data from messages

f8b45ad

separate MembraneWebRTC from dependencies to phoenix

29f22da

wip

726eee2

change name of events sent on websocket

dfd526d

Unify events names sent from backend to frontend

7e3436b

Remove MembraneWebRTCWrapper class

88848ad

Extract logic of showing bounded number of participants video tiles f…

cffe6fc

…rom MembraneWebRTC

Delete file with notes

d3af8b2

Merge utils files

cb8e87c

Rename Participant to Peer in frontend code

a4a8042

Rename MembraneWebRTC callbacks

678125e

Implement SFU engine - version with private key

003c6b1

Implement SFU engine - verison without private key

326e61e

Stop attaching fake stream to tile without video track

7b37113

wip refactor frontend

114b0b9

Refactor room.ts and membraneWebRTC.ts, use UUIDv4 ids

e8422e3

Remove showing up to 4 users on frontend

98d156d

Refactor room.ts and membraneWebRTC.ts - delete use of unnecessary

47cb9f6

functions

Integrate frontend with backend

d20c974

Remove screensharing

3ab0a32

Fix removing peers

1d08350

Fix tests

ca08105

Refactor code

701b8a1

Update deps

7fc5b46

mickel8 force-pushed the develop branch 3 times, most recently from f0deacf to 0cc228f Compare July 1, 2021 11:26

Eric Saxby and others added 2 commits July 9, 2021 13:28

Minor grammar fixes in Elixir docs

d39aa82

add data passthru for denial of peers by application code

db375c7

Signed-off-by: Austin Putman <austinp@geometer.io> Co-authored-by: Austin Putman <austinp@geometer.io>

Format js/mediaEvent.ts

1cfe9e5

mickel8 force-pushed the develop branch 2 times, most recently from 872eca6 to c611020 Compare July 9, 2021 12:12

Make credo happy

21cd11b

mickel8 force-pushed the develop branch from c611020 to 21cd11b Compare July 9, 2021 12:15

Check if TS code is formatted on CI

a8b1bfd

mickel8 force-pushed the develop branch from abb1640 to a8b1bfd Compare July 9, 2021 12:18

Refactor membraneWebRTC.ts

34cefc8

mickel8 force-pushed the develop branch from 4300d59 to 7beefef Compare July 12, 2021 15:23

Fix array comparision. Remove PeerConfig interface

d37827f

mickel8 force-pushed the develop branch from 7beefef to d37827f Compare July 12, 2021 15:44

mickel8 added 2 commits July 13, 2021 10:48

Don't invoke onPeerJoined in peerAccepted media event

a63165d

Don't check if media events have proper number of fields

f7839ef

mickel8 requested a review from mat-hek July 13, 2021 15:18

mat-hek suggested changes Jul 16, 2021

View reviewed changes

Use npm ci instead of npm install. Refactor code.

e762c84

mickel8 force-pushed the develop branch from bf6b70b to e762c84 Compare July 19, 2021 09:53

Rename callbacks onJoined and onDenied to onJoinSuccess and `on…

a7370cf

…JoinError` respectively

mickel8 requested a review from mat-hek July 19, 2021 12:09

mickel8 moved this from In progress to In Review in What's happening in Membrane? Jul 20, 2021

mat-hek approved these changes Jul 20, 2021

View reviewed changes

mickel8 merged commit 7365b84 into master Jul 20, 2021

What's happening in Membrane? automation moved this from In Review to Done Jul 20, 2021

mickel8 deleted the develop branch July 20, 2021 14:49

mickel8 removed this from Done in What's happening in Membrane? Jan 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

First version of SFU API #2

First version of SFU API #2

mickel8 commented Jul 1, 2021

mickel8 commented Jul 9, 2021 •

edited

Loading

mat-hek Jul 15, 2021

mat-hek Jul 15, 2021

mat-hek Jul 16, 2021

mat-hek Jul 16, 2021

mat-hek Jul 16, 2021

mat-hek Jul 16, 2021

sax commented Jul 18, 2021

mat-hek commented Jul 19, 2021

	* in a clean way e.g. by clicking dedicated, custom button `dissconnetc`.
	* in a clean way e.g. by clicking a dedicated, custom button `disconnect`.

		@@ -88,7 +105,7 @@ defmodule Membrane.SFU.MediaEvent do
		end

		defp do_deserialize(%{"type" => "join"} = event) do

First version of SFU API #2

First version of SFU API #2

Conversation

mickel8 commented Jul 1, 2021

mickel8 commented Jul 9, 2021 • edited Loading

mat-hek Jul 15, 2021

Choose a reason for hiding this comment

mat-hek Jul 15, 2021

Choose a reason for hiding this comment

mat-hek Jul 16, 2021

Choose a reason for hiding this comment

mat-hek Jul 16, 2021

Choose a reason for hiding this comment

mat-hek Jul 16, 2021

Choose a reason for hiding this comment

mat-hek Jul 16, 2021

Choose a reason for hiding this comment

sax commented Jul 18, 2021

mat-hek commented Jul 19, 2021

mickel8 commented Jul 9, 2021 •

edited

Loading