Match models whose name contains dots #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… add new test cases
This was referenced Apr 13, 2021
jtcohen6
reviewed
Apr 20, 2021
There was a problem hiding this comment.
@monti-python I feel similarly about this as I do about the related issues/PRs: All in favor, and even more eager to create more consistency and test coverage for this (previously-not-so-documented) feature :)
I'm having trouble replicating the specific issue you describe in the PR description. When I build docs locally, whether from this PR or from the head branch, I see all dot-named resources show up in the DAG viz—but when I focus/select a node with dots in its name, the selection clears all nodes from view.
Funny enough, the only resource type this does seem to work fine for is exposures:
It's possible I was missing something when testing locally.
jtcohen6
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #184
Description
In our dbt project we are managing multiple schemas. We are namespacing the models with the standard SQL syntax
<schema>.<relation>.sqland following this approach. It works quite well for the most part, however models with dots don't show up in the graphs on the generated docsChecklist
CHANGELOG.mdand added information about my change to the "dbt next" section.