Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when trying to call list_schemas macro for BigQuery adapter #2413

Merged
merged 3 commits into from
May 7, 2020
Merged

Fix error when trying to call list_schemas macro for BigQuery adapter #2413

merged 3 commits into from
May 7, 2020

Conversation

azhard
Copy link
Contributor

@azhard azhard commented May 6, 2020

resolves #2412

Description

Adds missing database parameter to adapter.list_schemas macro that is called by bigquery__list_schemas

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot
Copy link

cla-bot bot commented May 6, 2020

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Azhar Dewji.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented May 6, 2020

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Azhar Dewji.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@beckjake
Copy link
Contributor

beckjake commented May 7, 2020

@cla-bot check

@cla-bot cla-bot bot added the cla:yes label May 7, 2020
@cla-bot
Copy link

cla-bot bot commented May 7, 2020

The cla-bot has been summoned, and re-checked this pull request!

Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @azhard! I guess we don't call this as a macro very often.

Can you please add yourself as a contributor in CHANGELOG.md as well? I don't think the next release currently has one, so add a new contributors section like the ones in earlier releases and add yourself/this PR to it. That way we know to give you credit in the release notes.

CHANGELOG.md Outdated Show resolved Hide resolved
@beckjake
Copy link
Contributor

beckjake commented May 7, 2020

Thanks @azhard! I've kicked off tests and once they pass, we'll merge this.

@beckjake beckjake merged commit dfb72cc into dbt-labs:dev/octavius-catto May 7, 2020
@azhard azhard deleted the fix/bigquery-list-schemas branch May 7, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running BigQuery list_schemas macro produces error
2 participants