Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI stuff #2097

Merged
merged 1 commit into from
Feb 10, 2020
Merged

CI stuff #2097

merged 1 commit into from
Feb 10, 2020

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Feb 5, 2020 •
edited
Loading

Fixes #2033

  • Run unit tests + postgres on circle for outside PRs
  • Skip other integration tests on circle for outside PRs
  • Set an actual condition in AZP to skip running secure tests
  • build wheels after we pass tests

I think we also want to set circle CI's build-wheels job as required for all PRs on the github project, so third-party PRs won't look like they're ready to merge without the tests. (See #2100 for an example)

@cla-bot cla-bot bot added the cla:yes label Feb 5, 2020
@beckjake beckjake force-pushed the feature/ci-builds branch 2 times, most recently from 71623e2 to ce73abd Compare February 5, 2020 16:20
@beckjake beckjake marked this pull request as ready for review February 5, 2020 16:22
@beckjake beckjake requested review from drewbanin and removed request for drewbanin February 5, 2020 16:22
@drewbanin
Copy link
Contributor

I think we also want to set circle CI's build-wheels job as required for all PRs on the github project, so third-party PRs won't look like they're ready to merge without the tests. (See #2098 for an example)

I might be missing it, but is there an example of this in #2098?

@beckjake
Copy link
Contributor Author

beckjake commented Feb 6, 2020

Huh - I guess when I closed that PR without merging it removed the checks! When I get the branch working right for real tests I'll re-open that PR.

@beckjake beckjake force-pushed the feature/ci-builds branch 3 times, most recently from f171dd3 to 5ec4a82 Compare February 6, 2020 16:46
@beckjake
Copy link
Contributor Author

beckjake commented Feb 6, 2020

@drewbanin I've opened a new demo PR, #2100 - you can see the results there.

CI stuff
b5fc1ef 
circle: Run unit tests + postgres on circle for outside contributors automatically
circle+azure: skip non-postgres integration tests on for outside contributors
circle+azure: build wheels after tests pass
Update the docker image so venvs can pip install -U pip
drewbanin
drewbanin approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hell yeah! Ship it!

@beckjake beckjake merged commit 18358db into dev/barbara-gittings Feb 10, 2020
@beckjake beckjake deleted the feature/ci-builds branch February 10, 2020 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbanin drewbanin drewbanin approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run unit tests + flake8 for community-contributed PRs
2 participants
@beckjake @drewbanin