Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a user agent with version to the bigquery client info (#2121) #2146

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Feb 18, 2020

Updated unit tests

resolves #2121

Description

Add a user agent, as described in the issue.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue - I'm not sure how I'd know for sure, beyond the unit tests!
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Feb 18, 2020
@beckjake beckjake marked this pull request as ready for review February 18, 2020 16:26
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm! Nice one @beckjake :)

@beckjake beckjake merged commit 0c3fb95 into dev/barbara-gittings Feb 18, 2020
@beckjake beckjake deleted the feature/bigquery-user-agent branch February 18, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add user-agent "dbt-{version}" to the BigQuery connection
2 participants