Column and table comments for postgres/redshift (#2333) #2378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckjake
force-pushed
the
feature/pg-rs-persist-docs
branch
3 times, most recently
from
2d8f93a
to
d4ba35f
Compare
added 3 commits
April 30, 2020 14:49
- add some table comment framework stuff - have redshift/postgres catalogs include table comments - have redshift/postgres add comments to columns/tables/views - push some bigquery-specific formatting into bigquery - add tests for table comments
…se it - also fixed the default incremental to include that it is creating a table
beckjake
force-pushed
the
feature/pg-rs-persist-docs
branch
from
d4ba35f
to
c6603be
Compare
I didn't think about this at all! That's kind of a big problem IMO. We're overdue for a rethink on how materializations work (especially w/r/t these Reviewing this one now! |
drewbanin
approved these changes
May 4, 2020
7 tasks
McKnight-42
reviewed
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2333
Description
This is very much based off the work being done by @snowflakeseitz in #2321
I intentionally copy+pasted the common
adapter_macros to make merging easier.With this PR, redshift and postgres now generate column and table comments during view and table creation. Their get_catalog macros also now include those comments in the output (instead of null) and the end up in the catalog itself.
I added tests as well, of course!
Redshift is a little special:
One annoying/weird quirk we might need to think about: When you do have comments, results lines show up as
COMMENT in XXXsinstead ofCREATE TABLE in XXXs. That's a little goofy! Maybe comments should work like hooks do.Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.