Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: add --debug flag, replace all calls to print() with a streamhandler logger #256

Merged
merged 5 commits into from
Dec 24, 2016

Conversation

cmcarthur
Copy link
Member

@cmcarthur cmcarthur commented Dec 24, 2016

This branch:

  • Adds a --debug flag which prints dates and DEBUG level logs to the console during dbt runs. This will be useful for debugging.
  • Removes all print() statements in favor of logger... calls.
  • Removes writes to the logs/ directory in favor of writing to standard out.

@cmcarthur cmcarthur changed the title refactor out all calls to print(), replace with a streamhandler logger change: refactor out all calls to print(), replace with a streamhandler logger Dec 24, 2016
@cmcarthur cmcarthur changed the title change: refactor out all calls to print(), replace with a streamhandler logger change: add --debug flag, replace all calls to print() with a streamhandler logger Dec 24, 2016
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! LGTM

@drewbanin drewbanin assigned cmcarthur and unassigned drewbanin Dec 24, 2016
@cmcarthur cmcarthur merged commit a9161cf into development Dec 24, 2016
@cmcarthur cmcarthur deleted the refactor/global-logger branch December 24, 2016 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants