snowflake in windows #276
Merged
snowflake in windows #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
February 5, 2017 11:27
drewbanin
approved these changes
Feb 7, 2017
| @@ -51,6 +51,7 @@ install: | |||
| build: false # Not a C# project, build stuff at the test step instead. | |||
|
|
|||
| before_test: | |||
| - "%CMD_IN_ENV% pip install psycopg2==2.6.2" | |||
There was a problem hiding this comment.
Why do we need this in addition to the requirements.txt file?
There was a problem hiding this comment.
This installs psycopg2 from a wheel, which links it differently from doing a pip install. I'm not 100% certain tbh but I know it's necessary.
| - PYTHON: "C:\\Python27" | ||
| PYTHON_VERSION: "2.7.8" | ||
| - PYTHON: "C:\\Python35" | ||
| PYTHON_VERSION: "3.5.2" |
There was a problem hiding this comment.
Does this mean that Snowflake is only supported on Windows with py35?
There was a problem hiding this comment.
The implication is actually that dbt 0.7.0 is only supported on Windows with py35/py36. You can't even import the snowflake connector on py27 because of some weird relative imports.
There was a problem hiding this comment.
ok, noted. Are you able to update the installation docs for windows with this information?
yu-iskw
pushed a commit
to yu-iskw/dbt
that referenced
this pull request
Aug 17, 2021
Add integration tests Add accepted_range documentation Fixing invalid yaml in readme Add missing columns: entry Co-authored-by: Claire Carroll <carroll.claire.e@gmail.com> Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are finally passing